search

necolas / normalize.css

A modern alternative to CSS resets
http://necolas.github.io/normalize.css/
MIT License
52.48k stars 10.67k forks source link

hr normalize applying wrong overflow value #860

Open brady-shinners-bby opened 3 years ago

brady-shinners-bby commented 3 years ago

HTML5 spec for hr is to apply overflow: hidden, but normalize is currently applying overflow: visible. Please either remove what appears to be an unneeded override of a now-uniform default style or apply the expected overflow: hidden.

garrettw commented 3 years ago

Are you confirming that most browsers are respecting the spec now, or that the override definitely isn't needed anymore?

brady-shinners-bby commented 3 years ago

The override does the opposite of the spec. I'm not familiar with what normalize's target browsers are, so not sure on whether overflow: visible should be replaced with overflow: hidden or just removed. For my use-case, all browsers we support adhere to overflow: hidden.

garrettw commented 1 year ago

In my normalize in https://github.com/garrettw/vitals I'm making the change to hidden until I know for sure that it isn't needed anymore.