search

necst-telescope / necst

:gem: NEw Control System for Telescope
https://necst-telescope.github.io/necst/
MIT License
3 stars 0 forks source link

#213 change where send reduce command #214

Closed FumikaDemachi closed 1 year ago

FumikaDemachi commented 1 year ago

Checks

Related Issue

This PR closes #213.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.09% :warning:

Comparison is base (da4d5ed) 71.75% compared to head (1dd7623) 71.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== - Coverage 71.75% 71.66% -0.09% ========================================== Files 59 59 Lines 3105 3106 +1 ========================================== - Hits 2228 2226 -2 - Misses 877 880 +3 ``` | [Files Changed](https://app.codecov.io/gh/necst-telescope/necst/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope) | Coverage Δ | | |---|---|---| | [necst/procedures/observations/observation\_base.py](https://app.codecov.io/gh/necst-telescope/necst/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope#diff-bmVjc3QvcHJvY2VkdXJlcy9vYnNlcnZhdGlvbnMvb2JzZXJ2YXRpb25fYmFzZS5weQ==) | `31.62% <0.00%> (-0.84%)` | :arrow_down: | | [necst/procedures/observations/hot\_monitor.py](https://app.codecov.io/gh/necst-telescope/necst/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope#diff-bmVjc3QvcHJvY2VkdXJlcy9vYnNlcnZhdGlvbnMvaG90X21vbml0b3IucHk=) | `62.50% <100.00%> (+12.50%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/necst-telescope/necst/pull/214/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TatsumiISHIKAWA commented 1 year ago

シミュレータを使って試験をしようと思いましたが、Chopper Simulatorが正常に動作しないことに加え、numpyバージョンがよくないこと(neclibで対応済み)、#217 で解決済みの問題によって失敗しました。 今後はこの変更の動作試験を実機で行うか、Chopper SimulatorをAntenna Simulatorと同様に使えるように修正を行う#218 の変更から手をつけるかのどちらかが必須です。