necst-telescope / necst

:gem: NEw Control System for Telescope
https://necst-telescope.github.io/necst/
MIT License
3 stars 0 forks source link

[WIP] #226 change necst to new version #230

Closed takayama-27 closed 9 months ago

takayama-27 commented 10 months ago

Checks

Related Issue

This PR closes #226

TatsumiISHIKAWA commented 10 months ago

@takayama-27 Direct modeが反映されたneclibバージョンがリリースされました。 DockerFileのneclibバージョンを0.24.11に変更してテストを再度回してください。

TatsumiISHIKAWA commented 10 months ago

@TakutoIto @takayama-27 neclibのversion 0.24.12がpypiに上がったことを確認しました。 以前と同じようにDockerFileのneclib versionを書き換えてテストを回し直してください

codecov[bot] commented 10 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (74e0fd6) 69.98% compared to head (2577678) 69.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #230 +/- ## ========================================== - Coverage 69.98% 69.91% -0.08% ========================================== Files 61 61 Lines 3225 3234 +9 ========================================== + Hits 2257 2261 +4 - Misses 968 973 +5 ``` | [Files](https://app.codecov.io/gh/necst-telescope/necst/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope) | Coverage Δ | | |---|---|---| | [necst/core/commander.py](https://app.codecov.io/gh/necst-telescope/necst/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope#diff-bmVjc3QvY29yZS9jb21tYW5kZXIucHk=) | `52.41% <ø> (ø)` | | | [necst/ctrl/antenna/horizontal\_coord.py](https://app.codecov.io/gh/necst-telescope/necst/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=necst-telescope#diff-bmVjc3QvY3RybC9hbnRlbm5hL2hvcml6b250YWxfY29vcmQucHk=) | `73.64% <33.33%> (-1.90%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.