necst-telescope / necst

:gem: NEw Control System for Telescope
https://necst-telescope.github.io/necst/
MIT License
3 stars 0 forks source link

[WIP] #254 Add Powermeter.py #255

Closed takayama-27 closed 5 months ago

takayama-27 commented 5 months ago

Checks

Related Issue

This PR closes #254

TatsumiISHIKAWA commented 5 months ago

@takayama-27

takayama-27 commented 5 months ago

とりあえずneclibの方作るのでnecstは後回しで

r-yamada1998 commented 5 months ago

neclibのリリースをしていない+necstのDockerfileが

RUN ( cd $ROS2_WS/src/necst && pip install "neclib==0.25.1" && pip install ipython )

となっているので、powermeter.pyが呼んでいるneclibはこの前ふうなちゃんが作ったものがない状態になってます。 これどうしようね。一つはneclibをリリースしてもいいし、もう一つはdockerfileの中身を変えるかな。 どっちがいいだろう

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 51.61290% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 68.91%. Comparing base (ba995b4) to head (80be7ea).

Files Patch % Lines
necst/rx/powermeter.py 50.00% 13 Missing :warning:
necst/rx/__init__.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ========================================== - Coverage 69.01% 68.91% -0.11% ========================================== Files 64 65 +1 Lines 3318 3349 +31 ========================================== + Hits 2290 2308 +18 - Misses 1028 1041 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.