search

necst-telescope / necst

:gem: NEw Control System for Telescope
https://necst-telescope.github.io/necst/
MIT License
3 stars 0 forks source link

#320 modi config saving #321

Closed TatsumiISHIKAWA closed 1 month ago

TatsumiISHIKAWA commented 2 months ago

Checks

Related Issue

This PR closes #320

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.06%. Comparing base (f8541f3) to head (83a722c). Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
necst/procedures/measurement/measurement_base.py 16.66% 5 Missing :warning:
necst/procedures/observation_base.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #321 +/- ## ========================================== - Coverage 60.26% 60.06% -0.21% ========================================== Files 85 85 Lines 4291 4307 +16 ========================================== + Hits 2586 2587 +1 - Misses 1705 1720 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TatsumiISHIKAWA commented 1 month ago

@FumikaDemachi このFlake8（もしくはBlack）のCode FormatはおそらくCode Formatterの更新によるルールの変更による新しい書き方だと思うのですが...この変更は必須ですか？ neclibでは常にFlake8とBlackの新バージョンが出次第新しいルールが適用されるようになっているのですが、necstは手動更新でした。つまり、VSCode上のFlake8, Blackの新しいルールと、TESTコード上の古いバージョンのFlake8, Blackのルールと合わなかったのが原因でTESTが通らなのが問題だったので修正したのがこのISSUEの趣旨です。

ちなみにこの開業のルールはneclibでは既に反映されている変更です。 https://github.com/necst-telescope/neclib/commit/f60731f62ac2fbccbfc0b6c7f995f8b56a71108b