search

ned-code / moodle-block_marking_manager

3 stars 13 forks source link

Issues with display of 'marking status' tables #41

Closed tim3dwards closed 7 years ago

tim3dwards commented 7 years ago

Hi NED guys,

First off, thanks kindly for the awesome plugin!

We've discovered a problem with the 'marking status' tables that get put together to show correct / incorrect answers for a quiz. Only correct answers get added to the table, questions manually graded as incorrect (and description type questions) don't get included in the table as I presume they should.

As such, the ticks for correct answers do not line up with the relevant questions on the 'marking status' page.

If you look at the attached screenshot, the top half shows how a quiz was manually graded. You'll see there's 4 description type questions throughout the quiz. The first 5 gradable questions were marked '0', the last 5 marked '1'.

Now, look at the bottom half of the screenshot, which shows the table Marking Manager created to depict these scores. You'll notice only the correct answers are displayed, and do not correspond with the relevant questions. Below, in the orange outline, is a table I quickly mocked up in Photoshop which shows how I would expect the table to be displayed.

Moodle version - 3.3.2+ (Build: 20170922) Theme - Boost NED Marking manager version - 3.3.1 (2017083001)

Hope that's of use, let me know if you've got any questions about this.

Thanks,

Tim.

ned-marking-manager-issue

ned-code commented 7 years ago

Hi Tim, Thanks for the screenshots. This issues is fixed in latest version, which can be downloaded here https://moodle.org/plugins/block_fn_marking

tim3dwards commented 7 years ago

Fantastic, many thanks! When will the new version be released, please?

Best wishes,

Tim.

From: NED [mailto:notifications@github.com] Sent: 13 October 2017 01:10 To: fernandooliveira/moodle-block_marking_manager moodle-block_marking_manager@noreply.github.com Cc: Tim Edwards tim@Cambridgedigital.com; Author author@noreply.github.com Subject: Re: [fernandooliveira/moodle-block_marking_manager] Issues with display of 'marking status' tables (#41)

Hi Tim, Thanks for the screenshots. This issues is fixed in latest version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/fernandooliveira/moodle-block_marking_manager/issues/41#issuecomment-336314918, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfKaE6jMYSxVWxpxRZhEJ1u2o_mWMjEbks5srqpogaJpZM4P0Crp.

ned-code commented 7 years ago

Yesterday

tim3dwards commented 7 years ago

Great, thanks. I’ve installed the following build - block_fn_marking_moodle33_2017101200

Unfortunately the issue still exists in this release of the plugin too, nothing seems to have changed (see screenshot below). Aside from updating the plugin in Moodle, is there anything else we need to do?

[cid:image001.jpg@01D34436.DDDEDF50]

Kind regards,

Tim.

From: NED [mailto:notifications@github.com] Sent: 13 October 2017 12:06 To: fernandooliveira/moodle-block_marking_manager moodle-block_marking_manager@noreply.github.com Cc: Tim Edwards tim@Cambridgedigital.com; Author author@noreply.github.com Subject: Re: [fernandooliveira/moodle-block_marking_manager] Issues with display of 'marking status' tables (#41)

Yesterday

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/fernandooliveira/moodle-block_marking_manager/issues/41#issuecomment-336421740, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfKaEwPGUssFJVrvKO-ztZXXb0Iv-n8Cks5sr0QegaJpZM4P0Crp.

ned-code commented 7 years ago

Can you try to clear your cache? If that doesn't work, please post your screenshot again. I can't see it in your previous message.

tim3dwards commented 7 years ago

Yeah, cached was cleared fully (cookies / site data / cached images and files).

I’ll post up a screenshot on the bug tracker page for you.

Thanks,

Tim.

From: NED [mailto:notifications@github.com] Sent: 13 October 2017 16:04 To: fernandooliveira/moodle-block_marking_manager moodle-block_marking_manager@noreply.github.com Cc: Tim Edwards tim@Cambridgedigital.com; Author author@noreply.github.com Subject: Re: [fernandooliveira/moodle-block_marking_manager] Issues with display of 'marking status' tables (#41)

Reopened #41https://github.com/fernandooliveira/moodle-block_marking_manager/issues/41.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/fernandooliveira/moodle-block_marking_manager/issues/41#event-1292459394, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfKaE959wNEdqjlOA91cY-aFFzhfs3Ovks5sr3vZgaJpZM4P0Crp.

tim3dwards commented 7 years ago

I cleared Chrome browser cache in its entirety, and also purged the cache in Moode. Below is a screenshot using build 33_20171001200

image

ned-code commented 7 years ago

Hi Tim, please test latest Github code to see if this resolves this issue.

tim3dwards commented 7 years ago

Hiya,

That seems to have done the job, it’s working exactly as expected now.

Many thanks,

Tim.

From: NED [mailto:notifications@github.com] Sent: 17 October 2017 15:00 To: fernandooliveira/moodle-block_marking_manager moodle-block_marking_manager@noreply.github.com Cc: Tim Edwards tim@Cambridgedigital.com; Author author@noreply.github.com Subject: Re: [fernandooliveira/moodle-block_marking_manager] Issues with display of 'marking status' tables (#41)

Hi Tim, please test latest Github code to see if this resolves this issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/fernandooliveira/moodle-block_marking_manager/issues/41#issuecomment-337240579, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfKaE-Vvv3XJvEfH1AjeqdrtT4qSKWyKks5stLLFgaJpZM4P0Crp.