search

ned-code / moodle-block_mentor

7 stars 13 forks source link

Mentor can view all other mentees #49

Open jimkhoo opened 7 years ago

jimkhoo commented 7 years ago

Hi,

We are currently trialing NED Mentor Manager and even with the mentor-system role permission "View students that are not my mentees" set to Prevent or Prohibit, when a user who has been assigned as with mentor-system role logs in, this mentor can see their mentees listed on the block correctly. However in the "Progress report" page, the student drop down list will list all available Mentees including those not assigned to the mentor. Is this an expected behaviour or a bug?

In the previous version I am able to hide non assigned mentees by setting the permission for "Manage all" to Prevent or Prohibit.

Here's my Moodle environment details:

Moodle Version: 3.3.1 (Build: 20170710) Plugin version: 3.3.0 (2017072502) Database version: mariadb 10.0.32

ned_mentor_system_permission

ned-code commented 7 years ago

Do you mean the "All Students" view that is show here?

https://www.screencast.com/t/wtbEWA9lAXE

jimkhoo commented 7 years ago

I have the All Students unticked and the entry for all students are not showing. The issue I'm facing is related to the drop down list. Any user with the mentor role can see the names of all mentees on the drop down list. What I'm expecting is that a mentor can only see their own mentees on the drop down list. Thanks.

jimkhoo commented 7 years ago

We have upgraded our Moodle server to 3.3.2 over the weekend and reinstalled the mentor-roles as well as NED Mentor Manager. Looks like the issue has gone away and Mentors can only see their Mentees. I'm suspecting the previous issue could be due to the mentor roles were only created after NED was installed and the Manager role was assigned by default to NED Mentor Manager.

EDIT The issue is not caused by the roles. Apparently when I start using the Mentor Groups feature, setting a GROUP Leader will allow other mentors to view their own mentees as well as mentees in that specific group. Please advise if this is the intended feature. Thank you.