search

ned-kelly / docker-multicontainer-libretime

A multi-container deployment of the Libretime Radio Broadcast Server, PostgreSQL, Icecast2 & RabbitMQ, all based on Ubuntu Xenial & Alpine Linux!
56 stars 22 forks source link

pop-up stream player doesn't use FQDN #16

Open frecuencialibre opened 5 years ago

frecuencialibre commented 5 years ago

if you click the "listen" button, right below the "ON AIR" indicator in the top right of the web UI, it opens a window with an audio player. it appears to be hardcoded: 

setjPlayer('http://127.0.0.1:8000/airtime_128', 'oga', 'icecast');
ned-kelly commented 5 years ago

Right now the stream will default to whatever the FQDN of your Icecast server is in the configuration - the quick fix is to just specify the the Icecast Server as a FQDN rather than localhost or the internal name of the docker-container (how my libretime is setup to talk to the Icecast container).

A possible fix would be to proxy the pop-up player to the same host as the web-ui and then that can talk directly to whatever is configured in the Icecast settings - This way if you're accessing over a VPN etc it will still work fine (even if the Icecast server is not accessible directly).

For now - the quick solution is to just configure the Icecast server to whatever your public Icecast address is.

frecuencialibre commented 5 years ago

the stream will default to whatever the FQDN of your Icecast server is in the configuration

the configuration i've been able to find is at Settings > Streams in the web UI: screenshot from 2018-12-08 10-39-50

i'm submitting a PR now that gets us most of the way to resolving this out of the box.