ned-kelly / docker-voltronic-homeassistant

Programmatically read data from your Voltronic, Axpert, Mppsolar PIP, Voltacon, Effekta etc Inverter and send it to Home Assistant via MQTT - Works with RS232 & USB!
GNU General Public License v3.0
270 stars 144 forks source link

Refactoring #44

Open VolkArr opened 3 years ago

VolkArr commented 3 years ago

While trying to tune your code, I noticed one minor thing. if (linepart1 == "device") devicename = linepart2; else if (linepart1 == "run_interval") attemptAddSetting (& runinterval, linepart2); else if (linepart1 == "amperage_factor") attemptAddSetting (& ampfactor, linepart2); else if (linepart1 == "watt_factor") attemptAddSetting (& wattfactor, linepart2); else if (linepart1 == "watt_factor") attemptAddSetting (& wattfactor, linepart2); else if (linepart1 == "qpiri") attemptAddSetting (& qpiri, linepart2); else if (linepart1 == "qpiws") attemptAddSetting (& qpiws, linepart2); else if (linepart1 == "qmod") attemptAddSetting (& qmod, linepart2); else if (linepart1 == "qpigs") attemptAddSetting (& qpigs, linepart2); else continue; }

watt_factor is used twice;) And I would like to ask for your help. Everything works well in the console, but in Home Assistance, the data behaves very strange, they seem to freeze. How i can fix it?