search

ned-kelly / docker-voltronic-homeassistant

Programmatically read data from your Voltronic, Axpert, Mppsolar PIP, Voltacon, Effekta etc Inverter and send it to Home Assistant via MQTT - Works with RS232 & USB!
GNU General Public License v3.0
257 stars 140 forks source link

Tautology in inverter-cli/main.cpp #68

Closed dilyanpalauzov closed 1 year ago

dilyanpalauzov commented 2 years ago

https://github.com/ned-kelly/docker-voltronic-homeassistant/blob/master/sources/inverter-cli/main.cpp#L90 contains:

                else if(linepart1 == "watt_factor")
                    attemptAddSetting(&wattfactor, linepart2);
                else if(linepart1 == "watt_factor")
                    attemptAddSetting(&wattfactor, linepart2);

This is a tautology, which is fixed in https://github.com/manio/skymax-demo/commit/db91c5f97362572a2d89d25193c7f44b53b7028d .