Open mbevc1 opened 3 months ago
@mbevc1
init
on empty module list, I agree that a warning would be more appropriate than an error. Long term, if there is no modules.json
file, I'd like to check and see if there are any external modules in the config. If there are, prompt the user to run terraform init
. If not, let the user know that no external modules are found in the configuration with a warning.init
I guess, init
could run check
in the background and see if there's any divergence. If check
returns changes, then init
should prompt the user to run upgrade
. Otherwise, it could signal to the use that no changes are required.y
as well as yes
upgrade
operation. Do you have a suggestion for a different workflow?
init
and changing existing modules happens with upgrade
. Does that workflow make more sense?First three bullet points are addressed by PR #14
Couple of suggestions as it came across as a bit unintuitive when trying:
init
on empty module list probably shouldn't be an error and cold be a warning, so you could have module without submodules, thus just nothing to do. Perhaps you could check ifterraform init
was run and then report an issue?init
should probably be idempotent operation and running it again shouldn't error out:y
as well asyes
upgrade
operation? Maybe it's a future feature but currently doesn't seem there is a path for this and summary is reporting on this.