Fix build on android, and with LOGGING_LEVEL = 0

ned14 / llfio

P1031 low level file i/o and filesystem library for the C++ standard

https://ned14.github.io/llfio/

Other

881 stars 45 forks source link

Fix build on android, and with LOGGING_LEVEL = 0 #143

Closed patstew closed 3 weeks ago

patstew commented 2 months ago

Fixes building with LLFIO_LOGGING_LEVEL = 0, and a couple of minor issues that arose when building for android.

ned14 commented 1 month ago

Apologies for the delay on this. I have been ill, and what we actually really need here is a CI compiling everything for Android going forth.

ned14 commented 3 weeks ago

I think everything for this PR is now addressed. I didn't quite fix things as you did in your PR, however your PR was very useful in identifying what to change so thank you for that.

There is now an Android CI runner to ensure Android support doesn't regress in the future. It currently doesn't pass, but I'm prevented by the Boost release cycle from fixing it. When the next release of Boost goes out, that CI job should go green.

Thanks for the PR and sorry again about the wait.