ned14 / llfio

P1031 low level file i/o and filesystem library for the C++ standard
https://ned14.github.io/llfio/
Other
880 stars 45 forks source link

Simplify the selection for the dynamic thread pool implementation #96

Closed BurningEnlightenment closed 2 years ago

BurningEnlightenment commented 2 years ago

Note that I opted to use the custom implementation on linux by default even if libdispatch is available in order to prevent ODR violations caused mixing of gcc and clang.

Fixes #94

github-actions[bot] commented 2 years ago

Unit Test Results

2 files   -     4  0 suites   - 192   0s :stopwatch: - 34m 26s 0 tests  -   57  0 :heavy_check_mark:  -   57  0 :zzz: ±0  0 :x: ±0  0 runs   - 360  0 :heavy_check_mark:  - 360  0 :zzz: ±0  0 :x: ±0 

Results for commit 7986b922. ± Comparison against base commit b1825a23.

github-actions[bot] commented 2 years ago

Unit Test Results

    6 files  ±0  192 suites  ±0   25m 15s :stopwatch: - 9m 11s   57 tests ±0    57 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  360 runs  ±0  360 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7986b922. ± Comparison against base commit b1825a23.

github-actions[bot] commented 2 years ago

Unit Test Results

    4 files   -     2    62 suites   - 130   31m 51s :stopwatch: - 2m 35s   58 tests +    1    57 :heavy_check_mark: ±    0  0 :zzz: ±0  1 :x: +1  120 runs   - 240  119 :heavy_check_mark:  - 241  0 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit 7986b922. ± Comparison against base commit b1825a23.

github-actions[bot] commented 2 years ago

Unit Test Results

2 files   -     4  0 suites   - 192   0s :stopwatch: - 34m 26s 0 tests  -   57  0 :heavy_check_mark:  -   57  0 :zzz: ±0  0 :x: ±0  0 runs   - 360  0 :heavy_check_mark:  - 360  0 :zzz: ±0  0 :x: ±0 

Results for commit 7986b922. ± Comparison against base commit b1825a23.

github-actions[bot] commented 2 years ago

Unit Test Results

    4 files   -     2    62 suites   - 130   14m 31s :stopwatch: - 19m 55s   58 tests +    1    58 :heavy_check_mark: +    1  0 :zzz: ±0  0 :x: ±0  120 runs   - 240  120 :heavy_check_mark:  - 240  0 :zzz: ±0  0 :x: ±0 

Results for commit 7986b922. ± Comparison against base commit b1825a23.

github-actions[bot] commented 2 years ago

Unit Test Results

    6 files  ±0  192 suites  ±0   35m 55s :stopwatch: + 1m 29s   57 tests ±0    57 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  360 runs  ±0  360 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7986b922. ± Comparison against base commit b1825a23.

ned14 commented 2 years ago

Broken on MacOS? https://github.com/ned14/llfio/runs/8193009872?check_suite_focus=true