Fix Boost.System trait namespacing - Githubissues

ned14 / outcome

Provides very lightweight outcome<T> and result<T> (non-Boost edition)

https://ned14.github.io/outcome

Other

676 stars 62 forks source link

Fix Boost.System trait namespacing #206

Closed cstratopoulos closed 4 years ago

cstratopoulos commented 4 years ago

I noticed that the outcome_throw_as_system_error_with_payload(BoostErrorCodeEnum &&) page refers to the trait class boost::system::errc::is_error_meow_enum<BoostErrorCodeEnum>. As per the Boost.System docs the trait is spelled boost::system::is_error_meow_enum (no errc namespace).

Happily this error does not appear to be reproduced anywhere in the actual code:

error_code_registration.cpp puts the specialization in boost::system
boost_result.hpp just opens the namespace boost::system::errc so that (if I follow) ADL allows calling outcome_throw_as_system_error_with_payload(boost::system::errc::errc_t).

ned14 commented 4 years ago

Many thanks for the fix!