search

ned14 / outcome

Provides very lightweight outcome<T> and result<T> (non-Boost edition)
https://ned14.github.io/outcome
Other
676 stars 62 forks source link

C++20 removed std::is_literal_type #219

Closed 215020267 closed 4 years ago

215020267 commented 4 years ago

Description: In /std:c++17 mode, this triggers a deprecation warning in recent versions of MSVC. In /std:c++latest mode, now that microsoft/STL#380 has been merged, this will trigger an error in VS 2019 16.6 Preview 2.

Reproduce steps:

  1. git clone --recursive https://github.com/ned14/outcome D:\Outcome\src
  2. cd D:\Outcome\src
  3. mkdir build_amd64
  4. cd D:\Outcome\src\build_amd64
  5. cmake -G "Visual Studio 15 Win64" -DCMAKE_SYSTEM_VERSION=10.0.17134.0 .. 2>&1
  6. msbuild /m /p:Platform=x64 /p:Configuration=Release ALL_BUILD.vcxproj /t:Rebuild 2>&1

ErrorMessage: F:\gitP\ned14\outcome\test\tests\constexpr.cpp(31): error C2039: 'is_literal_type': is not a member of 'std' [F:\gitP\ned14\outcome\build_amd64\outcome_hl--constexpr.vcxproj]

ned14 commented 4 years ago

Was this not fixed in https://github.com/ned14/outcome/issues/218?