ned14 / pcpp

A C99 preprocessor written in pure Python
Other
215 stars 39 forks source link

Unhelpful exception when executing with no arguments #16

Closed virtuald closed 5 years ago

virtuald commented 5 years ago
$ pcpp
Traceback (most recent call last):
  File "virtualenvs/frc/bin/pcpp", line 11, in <module>
    sys.exit(main())
  File "virtualenvs/frc/lib/python3.6/site-packages/pcpp/cmd.py", line 195, in main
    p = CmdPreprocessor(sys.argv)
  File "virtualenvs/frc/lib/python3.6/site-packages/pcpp/cmd.py", line 50, in __init__
    args = argp.parse_known_args(argv[1:])
  File "/usr/lib64/python3.6/argparse.py", line 1766, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib64/python3.6/argparse.py", line 1975, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib64/python3.6/argparse.py", line 1931, in consume_positionals
    take_action(action, args)
  File "/usr/lib64/python3.6/argparse.py", line 1840, in take_action
    action(self, namespace, argument_values, option_string)
  File "virtualenvs/frc/lib/python3.6/site-packages/pcpp/cmd.py", line 20, in __call__
    items += [argparse.FileType('rt')(value) for value in values]
  File "virtualenvs/frc/lib/python3.6/site-packages/pcpp/cmd.py", line 20, in <listcomp>
    items += [argparse.FileType('rt')(value) for value in values]
  File "/usr/lib64/python3.6/argparse.py", line 1187, in __call__
    self._errors)
TypeError: expected str, bytes or os.PathLike object, not _io.TextIOWrapper
ned14 commented 5 years ago

Wow, that's a bad bug. Thanks for reporting this!

ned14 commented 5 years ago

Fixed. Thanks for reporting it!