search

ned14 / pcpp

A C99 preprocessor written in pure Python
Other
215 stars 39 forks source link

Fix bug where extra newlines are inserted when a multiline comment is encountered #38

Closed virtuald closed 4 years ago

virtuald commented 4 years ago
ned14 commented 4 years ago

Thanks for the PR. It'll be next week before I can look into this (WG21 mailing deadline).

ned14 commented 4 years ago

Thanks for reporting the problem and PR fixing this!

Letme commented 4 years ago

Why didnt you just merge this in? Now it seems like @virtuald didnt contribute :(

virtuald commented 4 years ago

@Letme doesn't matter to me, I just want it fixed. And he did give credit in his commit message.

ned14 commented 4 years ago

@Letme Apologies, no offense intended. I pulled the PR into the wrong branch, and switched to the correct branch using git reset soft. That ate the original contributor. It didn't occur to me that git history would be as important as the changelog.

Letme commented 4 years ago

Hi @ned14 , Well I think it is nice to give credit where credit is due as that is what matters. Sites like codersrank.io are starting to count contributors and it is always nice to look at contributors list to repository with a lot of different people. Low number of closed PRs also means your contribution will end up accepted. That all means that tool is easy to contribute to and that a lot of people care. You have a great repo here and I am a very happy user of it, just keep these small things in mind for future.