Closed QuellaZhang closed 3 years ago
This should have been fixed since. Can you confirm?
Thanks for the quick fix, verified that the following error can still be reproduced.
F:\gitP\ned14\outcome\build_amd64>C:\Python\Python37\python.exe F:/gitP/ned14/outcome/build_amd64/quickcpplib/repo/cmakelib/../pcpp/pcpp/pcmd.py -o F:/gitP/ned14/outcome/single-header/outcome-experimental.hpp F:/gitP/ned14/outcome/include/outcome/experimental/status_outcome.hpp F:/gitP/ned14/outcome/include/outcome/try.hpp -I ../quickcpplib/include --passthru-defines --passthru-unfound-includes --passthru-unknown-exprs --passthru-comments --line-directive --compress -U QUICKCPPLIB_ENABLE_VALGRIND -U DOXYGEN_SHOULD_SKIP_THIS -U DOXYGEN_IS_IN_THE_HOUSE -U STANDARDESE_IS_IN_THE_HOUSE F:\gitP\ned14\outcome\include\outcome\experimental\status_result.hpp:52 error: Could not evaluate expression due to SyntaxError("around token '// Do NOT enable weakened implicit construction for these types' type CPP_COMMENT2") (passed to evaluator: '0 // Do NOT enable weakened implicit construction for these types')
Confirmed. Relocating to the pcpp issue tracker, as the cause is there.
This should now be fixed completely. Thanks for the BR!
Hi All,
Outcome build failed on MSVC, this issue can be reproduced on latest version https://github.com/ned14/outcome/commit/a853fc09bb9590204a33c62bd3fd32f9b212c69f on VS2019 16.7.6, can you help look?
repro steps:
Build.log: build.log
Error info: "F:\gitP\ned14\outcome\build_amd64\outcome_hl-pp-experimental.vcxproj" (default target) (22:117) -> include/outcome/config.hpp : 128 error : Could not evaluate expression due to SyntaxError("around token '<' type CPP_LESS") (passed to evaluator: '!has_include()') [F:\gitP\ned14\outcome\build_amd64\outcome_hl-pp-experimental.vcxproj]
include/outcome/config.hpp : 288 error : Could not evaluate expression due to SyntaxError("around token '<' type CPP_LESS") (passed to evaluator: ' has_include()') [F:\gitP\ned14\outcome\build_amd64\outcome_hl-pp-experimental.vcxproj]
include/outcome/experimental/status_result.hpp : 52 error : Could not evaluate expression due to SyntaxError("around token '/ Do NOT enable weakened implicit construction for these types/' type CPP_COMMENT1") (passed to evaluator: '0 / Do NOT enable weakened implicit construction for these types/') [F:\gitP\ned14\outcome\build_amd64\outcome_hl-pp-experimental.vcxproj]