search

ned14 / pcpp

A C99 preprocessor written in pure Python
Other
215 stars 39 forks source link

Basic tox with pyenv setup for testing #74

Open assarbad opened 1 year ago

assarbad commented 1 year ago

Hope you find this suitable. If not I won't take offense. But I wanted to be able to test across a number of Python versions beyond just 3.7 and 2.7.

ned14 commented 1 year ago

Thanks for the PR. Doesn't tox also support windows?

assarbad commented 1 year ago

Thanks for the PR. Doesn't tox also support windows?

It does, but before adding it, I want to get Linux straightened out. And when that all works, I can deal with Windows, I suppose. One item at a time, though. (And I can't even ever test macOS.)

ned14 commented 1 year ago

Will you promise to me that if I merge this now that you will contribute tox support for windows?

assarbad commented 1 year ago

Will you promise to me that if I merge this now that you will contribute tox support for windows?

Frankly. Nope. And the reason isn't because I am lazy or unwilling to do it (in fact chances are you will see this from me). But I am unable to commit this and give you a reasonable time frame (and by reasonable I mean anything I would deem reasonable for my own projects).

If you don't want to merge it, that's fine with me. I'll simply try to maintain a branch with this patch rebased on latest master from you (and another branch combining my own as-of-yet unmerged patches). This way I can make use of it and drive the effort of increasing test coverage all the while not committing to a fixed deadline, which would seem dishonest to you if I don't make the deadline all the while making me feel terrible for not having made it 😉

Git for Windows uses a similar approach to stay "afloat" with the Windows-specific patches against the upstream master branch.

ned14 commented 1 year ago

Thanks for the honesty! I'm going to reopen this PR however, as roughly once per year I try to close all open bug count, merge all open PRs and do a release. If when that time comes this is still open I'll implement the windows support and merge it.