Hi. I have one item of critique currently. The assignment operators for status_code_domain::string_ref can't handle self-assignment nor does the copy-assignment operator provide strong exception safety. If string_ref gains a swap member function, these assignment operators can be rewritten using the copy/move-swap idiom. For efficiency, probably want to add the swap operation to _thunk_op.
Hi. I have one item of critique currently. The assignment operators for
status_code_domain::string_refcan't handle self-assignment nor does the copy-assignment operator provide strong exception safety. Ifstring_refgains aswapmember function, these assignment operators can be rewritten using the copy/move-swap idiom. For efficiency, probably want to add the swap operation to_thunk_op.