nedap / formatting-stack

An efficient, smart, graceful composition of Clojure formatters, linters and such.
Eclipse Public License 2.0
99 stars 2 forks source link

do not calculate classpath-cache on require #166

Closed thumbnail closed 3 years ago

thumbnail commented 4 years ago

Brief

This is reported to cause a lot of io, which could cause timeouts when when booting. By putting this into a delay the classpath-cache is calculated on the first kondo linter run.

QA plan

  1. release alpha
  2. remove .clj-kondo-folder from projects known to cause this issue
  3. boot repl; observe no timeout
  4. run f-s; observe creation of cache
  5. run f-s again; observe faster run

Author checklist

Reviewer checklist

thumbnail commented 3 years ago

mitigated by not loading f-s when the repl is loaded. instead we create aliases which use requiring-resolve to load f-s upon first reload / format.