nedap / formatting-stack

An efficient, smart, graceful composition of Clojure formatters, linters and such.
Eclipse Public License 2.0
99 stars 2 forks source link

clj-kondo improvements #174

Closed thumbnail closed 3 years ago

thumbnail commented 3 years ago

Brief

  1. Re-enables 'redundant' linters.
    • The formatters are run before the linters. So these shouldn't trigger. If they trigger they are missed by the formatter, and thus should be shown.
  2. enable parallelisation
  3. remove custom cache dir
    • Initially introduced to prevent 'locking' conflicts, clj-kondo currently has a retry making this redundant.
    • Allows running clj-kondo --parallel --lint "$(lein classpath)" to populate cache as expected.
  4. chunk analysing entire classpath
    • big classpaths can result in OOM. Chunking over them mitigates this (problem observed without parallelisation too)

QA plan

  1. postfix version project.clj with -dev
  2. lein install
  3. run (format-and-lint-project!) in projects to assert correct behaviour

Author checklist

Reviewer checklist

thumbnail commented 3 years ago

The changes in this PR will be addressed at a later moment.