search

nedap / formatting-stack

An efficient, smart, graceful composition of Clojure formatters, linters and such.
Eclipse Public License 2.0
99 stars 2 forks source link

formatting-stack.processors.test-runner/test!: return a useful value #176

Open vemv opened 3 years ago

vemv commented 3 years ago

Context

test! currently returns the fixed value nil. This makes it a limited primitive for creating more substantial functionality.

Task

Make it return a boolean depending on whether the test suite passed

Acceptance criteria

A boolean? is returned no matter what, even in face of exceptions (as they are common in WIP/failing/flaky tests)

thumbnail commented 3 years ago

Using a boolean now prevents expansion in the future.

What do you think about returning a map? It can yield :result? now, and possibly reports or tested-files in a later iteration.

vemv commented 3 years ago

Yeah returning the same map that clojure.test does seems best 👍