nedap / formatting-stack

An efficient, smart, graceful composition of Clojure formatters, linters and such.
Eclipse Public License 2.0
99 stars 2 forks source link

CI: adopt matrix syntax #186

Closed vemv closed 3 years ago

vemv commented 3 years ago

Brief

The project's build matrix predates CircleCI's matrix syntax. By using it, the build file can grow more sustainably - in particular we can add more elements / dimensions without having to review/adapt everything.

QA plan

Build this branch and observe that each named job is different and actually results in different setups/commands being executed.

image

Author checklist

Reviewer checklist

thumbnail commented 3 years ago

Is there something we can do about the jobnames? The jobnames overflow in the CircleCI interface, so they required to be opened before it's clear what the job configuration is. It's kinda messy.

Do like the transition to matrices though 🚀 !

vemv commented 3 years ago

Is there something we can do about the jobnames?

Following the docs, it looked like this would work:

diff --git a/.circleci/config.yml b/.circleci/config.yml
index be723e4..4982fe0 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -99,6 +99,7 @@ workflows:
           matrix:
             <<: *test_code_filters
             alias: "test_code_base"
+            name: "Serial - << matrix.jdk_version >> - << matrix.lein_test_command >>" 
             parameters:
               jdk_version: ["openjdk8","openjdk11"]
               lein_test_command:
@@ -109,6 +110,7 @@ workflows:
       - test_code:
           matrix:
             <<: *test_code_filters
+            name: "Parallel - << matrix.jdk_version >> - << matrix.lein_test_command >>"
             alias: "test_code_parallel_eastwood"
             parameters:
               jdk_version: ["openjdk8-parallel", "openjdk11-parallel"]

however I don't see a change in the UI