A given project's :acceptable-aliases-whitelist is augmented with the set of aliases that are used in the project and not new (per git: they don't belong to the git status or the git branch diff)
Needs refactor-nrepl latest (see) but degrades gracefully.
QA plan
Use f-s in a project that wasn't conforming to f-s' ns aliasing suggestions
Observe that existing aliases, even if non-conforming, will be fine
non-conforming new aliases will cause a linting fault.
This can be further verified by inspecting the formatting-stack.defaults/default-linters object, which will have a larger :acceptable-aliases-whitelist map.
Author checklist
[x] I have QAed the functionality
[x] The PR has a reasonably reviewable size and a meaningful commit history
[x] I have run the branch formatter and observed no new/significative warnings
[x] The build passes
[x] I have self-reviewed the PR prior to assignment
Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
[x] Correctness
[x] Robustness (red paths, failure handling etc)
[x] Test coverage
[x] Spec coverage
[x] Documentation
[x] Security
[x] Performance
[x] Breaking API changes
[x] Cross-compatibility (Clojure/ClojureScript)
Reviewer checklist
[ ] I have checked out this branch and reviewed it locally, running it
[ ] I have QAed the functionality
[ ] I have reviewed the PR
Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
Brief
Fixes https://github.com/nedap/formatting-stack/issues/204. The tldr is:
Needs refactor-nrepl latest (see) but degrades gracefully.
QA plan
This can be further verified by inspecting the
formatting-stack.defaults/default-linters
object, which will have a larger:acceptable-aliases-whitelist
map.Author checklist
Reviewer checklist