issues
search
nedap
/
speced.def
spec-backed forms of defn/defprotocol/..., aided by metadata
Eclipse Public License 2.0
67
stars
3
forks
source link
Use ghpr to pull ncrw & deploy to Clojars exclusively
#111
Closed
tcoenraad
closed
2 years ago
tcoenraad
commented
2 years ago
Brief
Use ghpr to pull ncrw & deploy to Clojars exclusively
QA plan
[x] test deploy
Author checklist
[x] I have QAed the functionality
[x] The PR has a reasonably reviewable size and a meaningful commit history
[ ] I have run the
branch formatter
and observed no new/significative warnings
[x] The build passes
[x] I have self-reviewed the PR prior to assignment
Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
[ ] Correctness
[ ] Robustness (red paths, failure handling etc)
[ ] Modular design
[ ] Test coverage
[ ] Spec coverage
[ ] Documentation
[ ] Security
[ ] Performance
[ ] Breaking API changes
[ ] Cross-compatibility (Clojure/ClojureScript)
Reviewer checklist
[ ] I have checked out this branch and reviewed it locally, running it
[ ] I have QAed the functionality
[ ] I have reviewed the PR
Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
[ ] Correctness
[ ] Robustness (red paths, failure handling etc)
[ ] Modular design
[ ] Test coverage
[ ] Spec coverage
[ ] Documentation
[ ] Security
[ ] Performance
[ ] Breaking API changes
[ ] Cross-compatibility (Clojure/ClojureScript)
Brief
Use ghpr to pull ncrw & deploy to Clojars exclusively
QA plan
Author checklist
Reviewer checklist