nedap / speced.def

spec-backed forms of defn/defprotocol/..., aided by metadata
Eclipse Public License 2.0
67 stars 3 forks source link

Implement support for destructuring #60

Closed vemv closed 5 years ago

vemv commented 5 years ago

Brief

Fixes nedap/utils.spec#22

Speced symbols within destructurings now get the usual benefits:

QA plan

Green build should suffice given the coverage added as part of this PR.

Author checklist

Reviewer checklist

vemv commented 5 years ago

PR Ready

Would appreciate if someone can assign himself to review it through the checklist (last one was too big so I didn't expect that then)

tcoenraad commented 5 years ago

I left a few remarks with regards to what I found confusing or thought could be formulated a bit sharper. We look forward to use this in Link 😄

vemv commented 5 years ago

Ready again. The separate issue https://github.com/nedap/utils.spec/issues/63 is b/c I have another branch going on and don't want to create a merge conflict

vemv commented 5 years ago

🍻!