nedbat / scriv

Changelog management tool
https://scriv.readthedocs.io
Apache License 2.0
260 stars 29 forks source link

[TODO][good first issue] Uncap `pylint-pytest` in the dependency lists and lock files #125

Closed webknjaz closed 6 months ago

webknjaz commented 6 months ago

It's pinned in a few files @ requirements/: https://github.com/search?q=repo%3Anedbat%2Fscriv%20pylint-pytest&type=code. This is due to https://github.com/reverbc/pylint-pytest/issues/20. The original project repository has been archived but the successor is being published to PyPI under the same project name and is hosted under @pytest-dev. They've ported my PR https://github.com/reverbc/pylint-pytest/pull/22 and merged it as https://github.com/pylint-dev/pylint-pytest/pull/15, releasing that under v1.1.6.

I just tried it out in another project and it ended up displaying a more informative error

. (C  0), ::F6401
************* Module cheroot.test.test_conn
cheroot/test/test_conn.py:L   1:(cannot-enumerate-pytest-fixtures) pylint-pytest plugin cannot enumerate and collect pytest fixtures. Please run `pytest --fixtures --collect-only cheroot/test/test_conn.py` and resolve any potential syntax error or package dependency issues. stdout: . stderr: ERROR: usage: pylint [options] [file_or_dir] [file_or_dir] [...]
pylint: error: unrecognized arguments: --numprocesses=auto --cov=cheroot --cov-report --cov-report xml:.test-results/pytest/cov.xml ~/src/github/cherrypy/cheroot--maintenance--macos-13/cheroot/test/test_conn.py
  inifile: ~/src/github/cherrypy/cheroot--maintenance--macos-13/pytest.ini
  rootdir: ~/src/github/cherrypy/cheroot--maintenance--macos-13

which made it more obvious that I'm lacking a few pytest plugins in the env where pylint is installed.

Action items

webknjaz commented 6 months ago

@olenayefymenko would you like to give it a go?

OlenaYefymenko commented 6 months ago

@OlenaYefymenko would you like to give it a go?

Yes, I'll solve this.

nedbat commented 6 months ago

Fixed in commit 53473f0fd108ade35df51d073fcb9cd9d56051bb