Closed plaguss closed 1 year ago
Thanks. I don't understand the failures here. I guess some esoterica about the requirement syntax?
Sorry, as per the setuptools docs on the setup.cfg, I wrote the python version for the extras with the commas:
[options]
zip_safe = False
include_package_data = True
packages = find:
install_requires =
requests
importlib-metadata; python_version<"3.8"
but it seems they are not expected with commas:
[options.extras_require]
pdf = ReportLab>=1.2; RXP
rest = docutils>=0.3; pack ==1.1, ==1.3
Running tox before:
scriv on stdlib-toml [?] via 🐍 v3.11.0 (.venv) on ☁️ (us-east-1)
❯ python -m tox -e py311
GLOB sdist-make: /home/agustin/github_repos/scriv/setup.py
py311 create: /home/agustin/github_repos/scriv/.tox/py311
py311 installdeps: -r/home/agustin/github_repos/scriv/requirements/test.txt
py311 inst: /home/agustin/github_repos/scriv/.tox/.tmp/package/2/scriv-1.0.0.zip
ERROR: invocation failed (exit code 1), logfile: /home/agustin/github_repos/scriv/.tox/py311/log/py311-2.log
================================================ log start =================================================
Processing ./.tox/.tmp/package/2/scriv-1.0.0.zip
Preparing metadata (setup.py): started
Preparing metadata (setup.py): finished with status 'done'
Requirement already satisfied: attrs in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (22.1.0)
Requirement already satisfied: click in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (8.1.3)
Requirement already satisfied: click-log in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (0.4.0)
Requirement already satisfied: jinja2 in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (3.1.2)
Requirement already satisfied: requests in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (2.28.1)
Requirement already satisfied: tomli in ./.tox/py311/lib/python3.11/site-packages (from scriv==1.0.0) (2.0.1)
ERROR: Could not find a version that satisfies the requirement python_version<"3.11"; extra == "toml" (from scriv[toml]) (from versions: 0.0.2)
ERROR: No matching distribution found for python_version<"3.11"; extra == "toml"
================================================= log end ==================================================
_________________________________________________ summary __________________________________________________
ERROR: py311: InvocationError for command /home/agustin/github_repos/scriv/.tox/py311/bin/python -m pip install --exists-action w '/home/agustin/github_repos/scriv/.tox/.tmp/package/2/scriv-1.0.0.zip[toml]' (exited with code 1)
and after the change:
scriv on stdlib-toml [?] via 🐍 v3.11.0 (.venv) on ☁️ (us-east-1)
❯ python -m tox -e py311
GLOB sdist-make: /home/agustin/github_repos/scriv/setup.py
py311 inst-nodeps: /home/agustin/github_repos/scriv/.tox/.tmp/package/2/scriv-1.0.0.zip
py311 installed: attrs==22.1.0,certifi==2022.9.24,charset-normalizer==2.1.1,click==8.1.3,click-log==0.4.0,coverage==6.5.0,exceptiongroup==1.0.4,freezegun==1.2.2,idna==3.4,importlib-metadata==5.1.0,iniconfig==1.1.1,jedi==0.18.2,Jinja2==3.1.2,MarkupSafe==2.1.1,packaging==21.3,parso==0.8.3,pluggy==1.0.0,pudb==2022.1.3,Pygments==2.13.0,pyparsing==3.0.9,pytest==7.2.0,pytest-mock==3.10.0,python-dateutil==2.8.2,PyYAML==6.0,requests==2.28.1,responses==0.22.0,scriv @ file:///home/agustin/github_repos/scriv/.tox/.tmp/package/2/scriv-1.0.0.zip,six==1.16.0,toml==0.10.2,tomli==2.0.1,types-toml==0.10.8.1,typing_extensions==4.4.0,urllib3==1.26.13,urwid==2.1.2,urwid-readline==0.13,zipp==3.11.0
py311 run-test-pre: PYTHONHASHSEED='789014312'
py311 run-test: commands[0] | python -V
Python 3.11.0
py311 run-test: commands[1] | coverage run -p -m pytest -Wd
=========================================== test session starts ============================================
platform linux -- Python 3.11.0, pytest-7.2.0, pluggy-1.0.0
cachedir: .tox/py311/.pytest_cache
rootdir: /home/agustin/github_repos/scriv, configfile: setup.cfg
plugins: mock-3.10.0
collected 162 items
tests/test_changelog.py .......
tox
seems to run fine.
Thanks!
This pr tries to solve the following issue: Python3.11, we can use the stdlib toml library #60.
I tried to modify the code as little as possible, hope it helps :)