search

nedialkova-lab / mim-tRNAseq

Modification-induced misincorporation tRNA sequencing
GNU General Public License v3.0
19 stars 14 forks source link

fix: open modomics file in read-only mode #50

Closed kelly-sovacool closed 1 year ago

kelly-sovacool commented 1 year ago

The existing code opens the local modomics file in r+ (read and write) mode, which fails in singularity/docker containers that aren't writeable (the preferred case). Since the file is only read and not written, there's no reason to open it in writeable mode.

This is related to #45

Thanks for maintaining this project, @drewjbeh. Not sure if you have any guidelines for contributors to abide by, so let me know if there's anything you'd like me to do.

drewjbeh commented 1 year ago

Hi @kelly-sovacool,

Thanks for your contribution! This makes total sense, code looks good so will merge. It should be integrated in the next release so watch out for it - stll waiting on the MODOMICS folks to fix the db (again, see #45 ). Hopefully early next week.

drewjbeh commented 1 year ago

Oh, and as of yet no real guidelines for contribution!