fix deprecated ServiceLocatorAwareInterface warning

neeckeloo / monolog-module

Monolog integration into Laminas

MIT License

8 stars 3 forks source link

fix deprecated ServiceLocatorAwareInterface warning #3

Open bvarent opened 8 years ago

bvarent commented 8 years ago

Fixed the deprecated ServiceLocatorAwareInterface warning by having the PluginManager factories inject the ServiceLocator themselves.

resolves #2

I found it hard to come up with a test for the issue. The deprecation warning is/was thrown when ZF2's ServiceManager applies the ServiceLocatorAwareInitializer to the PluginManagers created by MonoLog's *PluginManagerFactorys, and the initializer finds out that a ServiceLocator was not yet set.

coveralls commented 8 years ago

Coverage increased (+0.5%) to 90.179% when pulling e488d2c74ca78f9d248ac1a2df431fbfbbe3c5bc on bvarent:fix/deprecated-servicelocatoraware into d37bcb25e63dfab27a3b51832f6262109b5f7f33 on neeckeloo:master.

coveralls commented 8 years ago

Coverage increased (+0.5%) to 90.179% when pulling 5eeeb445e2793bc28b635bf9675c2a6b3b4eea6d on bvarent:fix/deprecated-servicelocatoraware into d37bcb25e63dfab27a3b51832f6262109b5f7f33 on neeckeloo:master.

coveralls commented 8 years ago

Coverage increased (+0.5%) to 90.179% when pulling dfa57c05e29a2c2fdfba61b60a9e3ef70c3f9b2e on bvarent:fix/deprecated-servicelocatoraware into d37bcb25e63dfab27a3b51832f6262109b5f7f33 on neeckeloo:master.

coveralls commented 8 years ago

Coverage decreased (-2.2%) to 86.232% when pulling 0bdeef15fb743e934ad258a2a2c10a8e68903bac on bvarent:fix/deprecated-servicelocatoraware into 237c9ac4eed24c47c5fc55d990c81ef8e4a3919a on neeckeloo:master.