need4swede / Portall

Port Management Interface
MIT License
309 stars 5 forks source link

Port arrangement doesn't stay #2

Closed Node815 closed 2 months ago

Node815 commented 2 months ago

When using the Drag and Drop to re-arrange ports to your liking it sticks, (For example Numerical). But when you add a new port mapping for a service, it reverts back to the original sort.

need4swede commented 2 months ago

So you re-order your ports, click the '+' to add a new port, and as soon as you do that all your ports go back to their previous order? Does this still happen if you refresh the page after re-ordering your ports?

Node815 commented 2 months ago

Yes, re-arranging and refreshing the page does this as well.

need4swede commented 2 months ago

Thanks for letting me know. I'll look into that right away.

need4swede commented 2 months ago

@Node815 Could you try the latest release and let me know if the problem still persists?

It does include some breaking changes to the database, so I suggest starting with a fresh database as I don't have any migration logic in place at the moment.

Node815 commented 2 months ago

I started with a fresh database and install - the arrangement now stays put and does not revert , but I do have one minor thing I noticed, the newly added port goes into position 2, then 3, then 4 regardless of the initial ordering: Before adding a new port: image After adding a new port ( I added Port 9999) image Adding another new port (I added Port 9998) image

You can see that the position stayed for port 9999, but the newly added 9998 shifted the "Portainer" port to the right. I can repeat this and each time, it pushes the original entries (As shown in the first screenshot) to the right after port 4001. While this is not a showstopper necessarily, the ordering should be in the order the end user adds it who can later organize the ports as desired.

need4swede commented 2 months ago

Thank you for the detailed response!

I think it would be best to have new ports appended to the very last position of the IP panel. I’ll add that to my todo list!