search

need4swede / Portall

Port Management Interface
MIT License
309 stars 5 forks source link

Editing Port keys off Port Number, not ID #8

Closed vinaykapadia closed 2 months ago

vinaykapadia commented 2 months ago

When editing a port, the endpoint uses the port number to pick which db row to edit. I've had it edit the wrong one because of this. Should key off row id. Or another way could be to prevent duplicates (it prevents duplicates when adding new, but you can edit a port to be the same as another).

Steps to reproduce:

  1. Add a port, call it A.
  2. Add a second port, call it B.
  3. Edit A to have the same port as B.
  4. Edit B to have another port, it will change the values for A instead.
need4swede commented 2 months ago

Edit: I've identified the problem and I'm currently testing the changes. Will be fixed in v1.0.3

Thank you for bringing this to attention. Added it to my list of bugfixes!

need4swede commented 2 months ago

@vinaykapadia could you give v1.0.3 a try and let me know if you're still experiencing issues?

You may have to start from a fresh database as there may have been some breaking changes along the way.

Thank you!

vinaykapadia commented 2 months ago

Will do!

vinaykapadia commented 2 months ago

Works great now, thanks!