JonathanPort
commented
5 years ago The point of open source is for people to come together and collaborate on code in aim to collectively improve that code. With that in mind, why don't you add in the translations yourself @JohannBlake ? At least spread the word so someone else can do it? @needim put in his own time to create this package. Like the rest of us, he probably has a job, family, commitments, etcetera. Why don't you help make this package "proper"?
Another note, people grow and learn. You may be on a different level comparing to another dev and so your definition of "properly" would also be different to that developer. What I'm trying to say is encourage and support people. Berating them isn't helpful. Especially if you need a feature haha
That aside, I do agree with the proposal however. This package will fundamentally need to be re written to make it viable for production. The amount of memory this package uses isn't adequate, at least for my client builds. Translations would also be nice.
The component is really nice but it is clear that it was not designed from the beginning to be used for efficient memory usage or for adding dynamically. If I add input editors dynamically and have many of them in my app, the picker's code is duplicated for every input taking up unnecessary memory. A better approach is to have just one instance created that can be opened and repositioned anywhere in the app and opened by a simple method.
Another criticism I have is that you hardcoded the the english text that you search for when someone searches for an emoji. WTF?? This is 2018 dude, not 1985 when developers hardcoded their text and english was in their minds the only language on the planet. If you're going to go through the hassle of writing open source, at least do it properly.