search

needle-innovision / nestjs-tenancy

Multi-tenancy approach for nestjs - currently supported only for mongodb with mongoose
MIT License
187 stars 58 forks source link

Change tenancy-options uri to Promise<string> or `string #14

Closed ephrimlawrence closed 2 years ago

ephrimlawrence commented 2 years ago

Making 'uri' promise allows for async operations such as fetching tenant database uri from primary database.

sandeepsuvit commented 2 years ago

Thank you @ephrimlawrence for the contribution.

ephrimlawrence commented 2 years ago

@sandeepsuvit The new release on npm (1.0.15) doesn't reflect the changes. I don't know if its from my end. Kindly check for me.

sandeepsuvit commented 2 years ago

Hi @ephrimlawrence your changes was mainly on this file

https://github.com/needle-innovision/nestjs-tenancy/blob/f977aad3a96d93cf80cff2d8c031eee952edb6a9/lib/interfaces/tenancy-options.interface.ts#L23

And i see the changes in the master. Can you check that please.

ephrimlawrence commented 2 years ago

Yes, I can see the changes on master but not when I install the package.

image

@sandeepsuvit This is a screenshot of the file in node_modules folder after updating to 1.0.15. On line 5, it hasn't changed. I have cleared my node_modules folder and reinstalled everything but it is still the same

sandeepsuvit commented 2 years ago

Hi @ephrimlawrence sorry the publish to npm registry somehow missed the updated artefacts and thats why your changes also went missing. Have added the fix now. You would get to see your changes in the latest version v1.0.18. Let me know if you can see them now.

ephrimlawrence commented 2 years ago

Hello, @sandeepsuvit I can see them now. Thanks for your help.

sandeepsuvit commented 2 years ago

Glad that helped ☺️