Open moparlakci opened 1 year ago
@sandeepsuvit ping
Hi @moparlakci thanks for the PR. I see that multiple core methods have been modified in this PR. Hence ill have to review this PR carefully so that the normal workflow isn't affected. Please give me some time to review it since i am currently busy with my other projects. Will update you here after i review it.
@sandeepsuvit okay understandable, thanks. Normally all tests are passing.
Hi @sandeepsuvit, is it possible to review this PR and merge it if it's working well?
Any update over this. This PR looks good! can you please merge this ?
Hi guys just follow up on this. When will this be ready?
I just grab the forked repo for this change. everything is working good in production thanks for fork man! @moparlakci
Hi Guys @Robokishan @jayzernguyenstarack @ezebrotsky This still needs some improvements, not 100% foolproof. I'll try to make some time for this, this week.
Have a nice day
Hi Guys @Robokishan @jayzernguyenstarack @ezebrotsky This still needs some improvements, not 100% foolproof. I'll try to make some time for this, this week.
Have a nice day
Thanks mate
hello, any update on this, I happened to run into the same use case mentioned in this pull request
PR for #37
Hi, can you review the changes, and maybe fix the request injection and request type check if you are more familiar with NestJs and Typescript than me :) Tests are passing for TCP clients, other clients like RMQ, Websockets, Graphql should pass when the request injection is done better.. The code is there but couldnt plug it together for all of them..