needle-mirror / needle-mirror.github.io

Readme and Website for Needle Mirror. Open an issue here for feature requests or issues
https://needle-mirror.github.io/
45 stars 6 forks source link

com.unity.xr.openxr not updating #11

Closed sjando closed 4 months ago

sjando commented 1 year ago

The mirror for the OpenXR package appears to be stuck at version 1.3.1 from 18+ months ago, but the package has been updated fairly regularly since then.

There's also a couple of new XR-related packages that aren't yet mirrored:

Really appreciate this resource btw. Thanks for the excellent work!

hybridherbst commented 1 year ago

Hey there!

We know about that package being excluded, at some point Unity changed the format of the package .tgz to something that our mirror backend can't open right now. (It's the only package with that format that we know of)

I added the other two, should show up soon if they don't happen to have the same issue 🤞

hybridherbst commented 1 year ago

New repos here: https://github.com/needle-mirror/com.unity.xr.hands https://github.com/needle-mirror/com.unity.xr.meta-openxr

sjando commented 1 year ago

Hey there!

We know about that package being excluded, at some point Unity changed the format of the package .tgz to something that our mirror backend can't open right now. (It's the only package with that format that we know of)

I added the other two, should show up soon if they don't happen to have the same issue 🤞

Thanks for adding the other two! Could the issue with OpenXR just be a one-off Unity CDN problem with version 1.4.0 specifically (the next version after 1.3.1) where the mirror gets stuck?

Not sure how your mirror backend works but I can successfully do:

curl https://download.packages.unity.com/com.unity.xr.openxr/-/com.unity.xr.openxr-X.Y.Z.tgz | tar zx

for every known version of the package except 1.4.0 (including 1.4.1 and beyond). 1.4.0 alone breaks, not because of the archive content, but because the CDN returns an XML error message instead of the actual archive.

I also note that 1.4.0 is excluded from the current CHANGELOG.md file and that in the package metadata versions 1.4.0 and 1.4.1 have identical values for upm.changelog, as though 1.4.0 is a known broken/revoked release.

hybridherbst commented 1 year ago

Good point, may be! I don't think we can skip individual versions via config right now (the assumption was "Unity doesn't upload and then keep entirely broken files"), so some changes on our end are needed to actually skip.

(or can we @marwie? maybe if we create an commit/tag in question manually?)

marwie commented 4 months ago

Sorry for taking so long but this has been fixed as of yesterday: https://github.com/needle-mirror/com.unity.xr.openxr