Some patches break methods completely

needle-tools / selective-profiling

Selectively deep profile single methods while your game is running in Unity's Profiler 🔬

135 stars 11 forks source link

Some patches break methods completely #2

Closed marwie closed 3 years ago

marwie commented 3 years ago

There seems to be a general issue in harmony when patching some specific methods.

Reproduced issue https://github.com/pardeike/Harmony/issues/390

This might also be responsible for errors when deep profiling ARFoundation components

marwie commented 3 years ago

~~TODO: test with harmony 2.1.0 (unreleased dev version)~~

tried with latest 381b72c48a9929c55e3469d2bd50b3176a6d5f89 but didnt help

marwie commented 3 years ago

Skipping properties seems to fix this issue for us for now. Profiling code inside property getters or setters should seldomly be useful anyways. Added Skip Properties to settings