search

neekey / ps

A Node.js module for looking up running processes
MIT License
128 stars 41 forks source link

Pass PID list into wmic query to speed things up on Windows. #73

Open smcpeck opened 6 years ago

smcpeck commented 6 years ago

This is definitely a hack that only works when querying by PID, which is my use case. It'll partially address #60 and #68.

It sped things up on Windows from 19 seconds to 0.25 seconds. So it definitely works. Surely, it would be great if someone takes this concept and fills it out to handle other use cases.

smcpeck commented 6 years ago

Not sure why these tests are failing. After some investigation, it doesn't seem to be related to my changes.

szikszail commented 6 years ago

@neekey , @smcpeck would it be possible to kick these changes into gear? We really suffer from the bad performance when gathering info about only 1 process on Win and this would help a lot! THank you!

smcpeck commented 6 years ago

@szikszail I still have no idea why the unit tests were failing here. Maybe things are better now and I could merge develop back into my branch to give things a shot. This is something I can try and look at in a few weeks when I have a bit more free time.

Otherwise, maybe @neekey can manually fire off another run of the CI pipelines to see if things will pass now?

aabluedragon commented 1 year ago

This is very useful and works fine, should be merged.