neekey / table-parser

A parser to parse table style output from shell
MIT License
25 stars 13 forks source link

Change test/output/aux.log filename #6

Closed diegomarcov closed 7 years ago

diegomarcov commented 7 years ago

Hi! Your last update added or changed the test/output/aux.log file. This is creating issues in Windows. The AUX filename is reserved in Windows, and clonning your repo immediately fails:

$ git clone https://github.com/neekey/table-parser
Cloning into 'table-parser'...
remote: Counting objects: 85, done.
remote: Total 85 (delta 0), reused 0 (delta 0), pack-reused 84
Unpacking objects: 100% (85/85), done.
Checking connectivity... done.
error: unable to create file test/output/aux.log (Permission denied)
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Also, packages like ps-node use table-parser as a dependency and I'm having trouble with those while trying to package my app (because the aux.log file can't be harvested).

Can you please rename this file?

Thanks!

neekey commented 7 years ago

@diegomarcov Thanks for this issue report, I didn't know this and just reproduced this issue. Will fix this soon.

Just for reference:

https://ionicflux.wordpress.com/2006/09/02/windows-reserved-words/

neekey commented 7 years ago

@diegomarcov fixed in table-parser@0.1.3 and ps-node@0.1.4