neelance / ffi_gen

A generator for Ruby FFI bindings, directly from header files via LLVM's Clang compiler
MIT License
88 stars 26 forks source link

Keep macro identifer. #17

Closed novogrammer closed 12 years ago

novogrammer commented 12 years ago

Keep macro in macro expression. But there is Problem with concat string.

//OK

define A 1

define B A+1

//NG

define A "a"

define B "b" A

neelance commented 12 years ago

Do you really expect me to merge something that breaks my test cases? Please run "rake test", i can not merge something if that fails. And I say it a third time: Please use my code style if you want it merged.

novogrammer commented 12 years ago

Sorry,I was wrong. This is issue. I close this pull request.

And I say it a third time: Please use my code style if you want it merged.

In this commit,Please tell me what is the difference?

novogrammer commented 12 years ago

I have an idea. Extract string literal from Define. Because, Ruby do "string literal concatenation", like C.

"Hello " "World!" # => "Hello World!" hello="Hello " hello "World!" # NoMethodError: undefined method `hello'