Closed novogrammer closed 12 years ago
Hi novogrammer, thanks for your work on ffi-gen. But its a little bit problematic, that you've waited so long to do a pull request, because looking through such a big list of commits is more difficult for the project owner. I will do it, but I need to ask you to adapt your changes to my coding conventions first. Thanks, neelance
Hi neelance, I'm sorry for bothering you. What should I do? Do you need to create a branch for each feature? Thanks, novogrammer
Yes, individual branches and a separate pull request for each feature would be a lot easier to handle. You can then write in the pull request what your intentions for the change were and I can ask back questions or pull the changes if i am OK with them. And as I said, please use my coding conventions for white space etc.
I understand.I close this pull request. I'll send these pull request later.
Great! Thanks.
Hi,neelance. I’m sorry. I have kept you waiting. I sent these pull request. Thanks
+1
I have some features for handling binary data with Ruby-FFI.