search

neelbhat88 / imuadev

2 stars 0 forks source link

Progress page form validations #536

Open ttapers opened 10 years ago

ttapers commented 10 years ago

i.e. Making sure all required fields have been entered, and pumping a descriptive error to the UI if they haven't.

neelbhat88 commented 10 years ago

Jake, this one relates to the testing one you are working on with the save button not showing

Neel [Sent via mobile phone] On Oct 10, 2014 5:13 PM, "Pat Hogan" notifications@github.com wrote:

i.e. Making sure all required fields have been entered, and pumping a descriptive error to the UI if they haven't.

— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/issues/536.

neelbhat88 commented 10 years ago

We thought of a few directive ideas on how this would work - just need to figure out the details of how possible it would be to do the ideal approach. Let's discuss these when this is started

ttapers commented 10 years ago

Do we want this in sprint 7 or 8 (or parts in both)?

neelbhat88 commented 10 years ago

I think Sprint 8 is fine. We haven't had any validations on the progress data up until now really so another few days/week without it is fine.

Neel Bhat

On Wed, Oct 15, 2014 at 10:28 AM, Pat Hogan notifications@github.com wrote:

Do we want this in sprint 7 or 8 (or parts in both)?

— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/issues/536#issuecomment-59224353.

neelbhat88 commented 10 years ago

We can push this to production as soon as its done and we've added some basic front end validations on the progress pages (null values). We can then dive real deep with this if we want and put in validations for things like has to be a valid phone number, etc but this will at least set the foundation for doing that later if we want

Jakeah commented 10 years ago

This is currently checked into the new_validations branch with angular v1.3 installed

neelbhat88 commented 10 years ago

Alright cool, let's wait until we push to this new stuff to Prod and then merge that in after making sure we all understand what changes angular 1.3 made and how to use the new validations. We can spend a few hours later this week maybe where you give us a run through of that

Neel Bhat

On Mon, Oct 27, 2014 at 10:50 AM, Jake Connors notifications@github.com wrote:

This is currently checked into the new_validations branch with angular v1.3 installed

— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/issues/536#issuecomment-60615966.

Jakeah commented 9 years ago

This issue is being left open until all forms on the progress page have this impelmented