Closed Jakeah closed 9 years ago
I just realized I don't have a controller test in for the GPA controller. I'll add that before merging.
Can you see if you can figure out how to get this up in one of your personal apps first so we can play around with it there? Let me know what issues you're having creating a new heroku app or pushing to your old app (have you tried doing a git push yourapp yourbranchname:master --force?) and we can try and figure it out
Neel Bhat
On Mon, Mar 30, 2015 at 1:51 PM, Jake Connors notifications@github.com wrote:
I just realized I don't have a controller test in for the GPA controller. I'll add that before merging.
— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/pull/809#issuecomment-87789515.
You can checkit out now on:
jakeimua.herokuapp.com
Might want to restrict the values that can be entered to be between 0 and 4.0?
On Wed, Apr 1, 2015 at 12:33 PM, Jake Connors notifications@github.com wrote:
You can checkit out now on:
jakeimua.herokuapp.com
— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/pull/809#issuecomment-88567629.
Mark B. Cassidy Westside Children's Therapy http://westsidechildrenstherapy.com/ (815)-545-7182 | mcassid3@gmail.com
Also - might want to add a "Are you sure you want to do this?" prompt when you have a GPA entered (no classes) and then add a class. User might not realize that that wipes out the GPA with the calculated GPA.
On Wed, Apr 1, 2015 at 12:46 PM, Mark Cassidy mcassid3@gmail.com wrote:
Might want to restrict the values that can be entered to be between 0 and 4.0?
On Wed, Apr 1, 2015 at 12:33 PM, Jake Connors notifications@github.com wrote:
You can checkit out now on:
jakeimua.herokuapp.com
— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/pull/809#issuecomment-88567629.
Mark B. Cassidy Westside Children's Therapy http://westsidechildrenstherapy.com/ (815)-545-7182 | mcassid3@gmail.com
Mark B. Cassidy Westside Children's Therapy http://westsidechildrenstherapy.com/ (815)-545-7182 | mcassid3@gmail.com
Yeah we want to make sure from the UI it is very clear to the user what this means. A popup message, maybe text around it, a ? icon that gives you more info when you click it, etc - whatever will look nice but make it very clear.
Also, how do you get to this?
Neel Bhat
On Wed, Apr 1, 2015 at 12:48 PM, mcassid3 notifications@github.com wrote:
Also - might want to add a "Are you sure you want to do this?" prompt when you have a GPA entered (no classes) and then add a class. User might not realize that that wipes out the GPA with the calculated GPA.
On Wed, Apr 1, 2015 at 12:46 PM, Mark Cassidy mcassid3@gmail.com wrote:
Might want to restrict the values that can be entered to be between 0 and 4.0?
On Wed, Apr 1, 2015 at 12:33 PM, Jake Connors notifications@github.com wrote:
You can checkit out now on:
jakeimua.herokuapp.com
— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/pull/809#issuecomment-88567629.
Mark B. Cassidy Westside Children's Therapy http://westsidechildrenstherapy.com/ (815)-545-7182 | mcassid3@gmail.com
Mark B. Cassidy Westside Children's Therapy http://westsidechildrenstherapy.com/ (815)-545-7182 | mcassid3@gmail.com
— Reply to this email directly or view it on GitHub https://github.com/neelbhat88/imuadev/pull/809#issuecomment-88572634.
@Jakeah just added a small comment. Once you fix that merge away! Mark called to see if we can get this into Prod today so whenever you merge and get it into staging I'll do a Prod deploy with it
-Can only override GPA if there are no classes entered for a given semester (time_unit). -Play with this on staging before pushing to master.