search

neelbhat88 / imuadev

2 stars 0 forks source link

Chad fixes #810

Closed Jakeah closed 9 years ago

Jakeah commented 9 years ago

You can now save a new service organization without a description. Stars no longer show up if leadership is null or empty. Hover over no longer interferes with student select bar Progress Page and Academic page fixes are in as well

neelbhat88 commented 9 years ago

Looks good, merge away

neelbhat88 commented 9 years ago

@Jakeah also I just realized this as I was taking a look at this in some more detail - the service org description should still be mandatory. The issue wasn't that it was required, the issue Chad was having is that it wasn't obvious that it was required - All the other input boxes get the red "This field is required" text if you try and save it without those values. The description field does not get that text (you can see it in http://imuaneel.herokuapp.com)

Can you change it back so the field is still mandatory (we want students entering in descriptions always for service) but you get the "This field is required" message if you don't enter it? Thanks