neerajrathore / javascript-handbook

A handbook 📚 that summaries concepts of JavaScript.
https://javascript-handbook.vercel.app
MIT License
25 stars 39 forks source link

Combine Logo Fixes and Destructuring Topic into One Contribution #99

Closed Shinu-ster closed 1 month ago

Shinu-ster commented 1 month ago

This pull request combines the changes from two previously submitted PRs (#96 and #97) to avoid conflicts and simplify the contribution process. Included Changes:

  1. Fixed logos and added social media links:

    • Updated index.html to include new logos and social media sharing links.
    • Updated the CDN references to ensure proper display of assets.
  2. Added Destructuring Topic:

    • Created a new folder for the "Destructuring" topic.
    • Added an index.html and README.md inside the new folder.
    • Updated the main index.html to include a link to the "Destructuring" section.

This combined PR resolves conflicts in index.html and ensures both contributions are integrated smoothly.

Let me know if you need further edits or details for the PR!

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-handbook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 3:32pm
neerajrathore commented 1 month ago

@Shinu-ster Thanks you for your contribution.

but adding two new files and updating one index file can be done in single commit, and you have 4 commits which is merging from your previously used branch. and after merging all this commits will show in main branch which will be not relevant to understand.

I think you should follow this -

I hope you understand this and if you have any doubts then tell me.

Shinu-ster commented 1 month ago

@neerajrathore Appreciate the comment A new PR is on the way. I followed all the steps you listed hope you are satisfied and it clears all the confusion