search

neerajsingh0101 / admin_data

A non instrusive gem which helps you browse, search and manage your data using browser
http://admin-data-demo.heroku.com/admin_data
MIT License
376 stars 56 forks source link

updated routes and regenerated gemspec #64

Closed axs89 closed 13 years ago

axs89 commented 13 years ago

Hi-

Per https://github.com/neerajdotname/admin_data/issues#issue/63, I've updated the routes file and regenerated the gemspec.

Thanks,

Arun

neerajsingh0101 commented 13 years ago

Your changes look good. However I am not sure why you removed

return lambda {|controller| return true } if Rails.env.development?

axs89 commented 13 years ago

Well, I added this commit in after the pull request (didn't think that would also show up in the request). I was trying to add and test my custom authorization in development, and (before I looked into the code) wasn't sure why it wasn't getting called at all. I think that it makes sense as default behavior, but once a authorization block is passed maybe it should always call that block regardless of the environment? That's how I read the docs. I'll update my fork along with this approach and you can see if that makes more sense.

neerajsingh0101 commented 13 years ago

Commit has been pushed. Thanks.