search

neerajsingh0101 / admin_data

A non instrusive gem which helps you browse, search and manage your data using browser
http://admin-data-demo.heroku.com/admin_data
MIT License
376 stars 56 forks source link

Paperclip and has_friendly_id support #67

Closed capotej closed 9 years ago

capotej commented 13 years ago

I added support for file uploads (paperclip) and fixed some errors when used with has_friendly_id. Thanks for writing a great plugin!

neerajsingh0101 commented 13 years ago

Thanks for the pul request. I will have to write a cucumber test for the if condition that you added. Once the test is done then I will merge it.

On a lighter note I thought I was the only guy using this gem since rails_admin is so popular.

capotej commented 13 years ago

If I knew how to test it I would, I was just pushing and testing it live with my app (hence all the commits), I'll look forward to reading the test though.

I actually found your gem to be a little better than rails_admin because it was light and simple, rails_admin hangs when loading large associations (when I don't even care about association editing to begin with!). So, good job on keeping it simple.

neerajsingh0101 commented 13 years ago

To make admin_data work with friendly_id see the solution presented here

https://github.com/neerajdotname/admin_data/issuesearch?state=open&q=friendly#issue/65

In this way we don't need to have .id everywhere .

If this solution works for you then send another pull request only for paperclip support.

neerajsingh0101 commented 9 years ago

We are no longer supporting admin_data. Thanks for the pull request.