search

neerajsingh0101 / admin_data

A non instrusive gem which helps you browse, search and manage your data using browser
http://admin-data-demo.heroku.com/admin_data
MIT License
376 stars 56 forks source link

Advanced Search #8

Closed kulpreet closed 15 years ago

kulpreet commented 15 years ago

Click on condition after selecting a boolean column, results in a JS exception

From firebug -

AdminDataJSUtil.column_options[col1_type] is undefined [Break on this error] var options = AdminDataJSUtil.column_options[col1_type]['options'];\n

There is no exception if the boolean column is selected as a second row. But it shows no conditions in the conditions drop down.

Other column types work. This is on postgres, just in case it matters.

neerajsingh0101 commented 15 years ago

Well that gives me a perfect excuse to write test for JavaScript. I will work on it. Thanks for reporting.

kulpreet commented 15 years ago

Found the problem. There is a typo in adv_search.js L219.

The options are set for booleant instead of boolean. Therer's an extra 't'. Hope that helps.

neerajsingh0101 commented 15 years ago

Try now. It should be fixed. Thanks for pointing out the bug.

This commit fixes it. http://github.com/neerajdotname/admin_data/commit/b2f04486755a73587485d428d4016423df3779f6

neerajsingh0101 commented 15 years ago

Closing this issue