Rework how LEDs are set throughout out driver

nefarius / DsHidMini

Virtual HID Mini-user-mode-driver for Sony DualShock 3 Controllers

https://docs.nefarius.at/projects/DsHidMini/

BSD 3-Clause "New" or "Revised" License

1.27k stars 55 forks source link

Rework how LEDs are set throughout out driver #351

Open Kanuan opened 7 months ago

Kanuan commented 7 months ago

LEDs are set in many different parts of the driver, and in each of them they do their logic on if they should or not set the LEDs based on the current LED authority.

This need to be reworked so simplify the code and to better manage LED states

Kanuan commented 6 months ago

To better mimic the PS3:

The 5 bytes related to a given LED effect should be all zeroes if the related LED flag is not set
For static LEDs, PS3 uses the following effect FF.00.01.00.01
- This is: FF: Effect lasts infinitely; 00.01: portion duration equal to "1"; 00: No off portion; 01: On Portion Multiplier = 1;
- We already know this is necessary for the LEDs in some replicas to behave correctly, see: #365